G40 Redesign (currently taking suggestions)

@waxfingers right :muscle:

yea went through. I’ll try an update tonight. Kinda burnt but I might rally with a second wind lol

so Game Notes and all is ready to go ? Ready to update to Git/triplea ?

@barnee

Yes, updated version, added game notes. Tested what I could. Went through rounds, tried edit. Seems to be all good.

@waxfingers right on i’ll try n get to it soon

@waxfingers does this have the China Arty fix also ?

Ok just checked. I’m gonna look at it and add to the update. Shouldn’t be too hard I wouldn’t think, so probably sometime later today.

Update to 2.678

Change Log: 2.678

10/1/21
Adds “Battleships and Carriers 2 Round Purchase” to map options. Adds “Escort Carriers 1 Movement” to map options. Also Fixes Chinese Artillery not placing correctly.

“Battleships and Carriers 2 Round Purchase” and Escort Carriers 1 Movement” not currently available in Canada mod.

@waxfingers yea when I made the “Military Base” place only Infantry is when I screwed up the Chinese Arty placement.

Yea I like to update both mods at the same time unless it’s just a Canada only one. Gets a bit tiresome but once you got it dialed in the first time it goes faster the next one.

Anyway, when you get a chance, if you would update Canada also, will put it in the next update. They seem like cool options.

Good work man.

@barnee

No problem, I did do it for the BB right? I think it was easier to do it at the same time because the code is fresh in mind. I will send you that as well. Do I just need to send you the game file then? I will need Canada units too actually. How do you want to go about this?

@waxfingers yea you did it for the French BB. Easiest is to just send the whole zip like you did last time.

Yea Idk what all you added to make the change so it’s easier for you to do it. i might miss something and I’d have to test etc…

We’ll get you dialed in at Git one of these days and then you can just add stuff direct. Seems you have a pretty good grip on things. Definitely know some stuff i don’t :)

@barnee

OK, the zip file is on its way to you.

You will need to add in your China fixes again, or at least just for the Canada one, I did not touch the Regular XML file.

Haha, this stuff is all new to me, but I am pretty good at just playing around with things and figuring out problems. A lot of analyzing existing code and seeing how I can manipulate it.

@barnee

One thing actually I was just thinking about adding to notes. Because the BB hull carrier had to be a different unit (I don’t think it will be used much, if at all) but it does create a separate carrier unit in the same sea zone. Maybe a note to just edit the carrier to a regular one after placement to keep the board clean.

@waxfingers said in G40 Redesign (currently taking suggestions):

Haha, this stuff is all new to me, but I am pretty good at just playing around with things and figuring out problems. A lot of analyzing existing code and seeing how I can manipulate it.

yea it’s kinda like a puzzle lol

@waxfingers said in G40 Redesign (currently taking suggestions):

@barnee

One thing actually I was just thinking about adding to notes. Because the BB hull carrier had to be a different unit (I don’t think it will be used much, if at all) but it does create a separate carrier unit in the same sea zone. Maybe a note to just edit the carrier to a regular one after placement to keep the board clean.

Hmm… can you trigger it to remove and place ? Are there limited SZs where the Hulls can be built/placed ? Might not be too bad if that’s the case.

Anyway, be best for you to write up what you want for a note and I’ll add before update. Idk enough about how they work to be confident in doing one. You can just post it here if you want.

@waxfingers so I updated the Canada mod, not to triplea yet, and I noticed, non Canada mod was what I was on, that I could launch a CV without a Drydock.

It seems Germany should have to place the Drydock G1 before it can then buy a CV G2 and place once the CV Hull is moved into the water ? Is that correct ?

Also I noticed that I couldn’t place the Drydock anywhere. I just had the BB and CV 2 rd build and Escort CV M1 on for options.

It throws a notification error when moving the Hull into the sea too. Not a biggie as it can be ignored but we should make a notification for it at Game start the way the A0C5 Bmbrs work.

Actually, somebody found a solution to that but I never implemented it. I’ll have to look it up at triplea.

But yea it seems that Drydock is the issue.

Edit
It says Drydock is an upgrade of an Inf. Not sure that’s what you intended but it’s not placing even with Inf present.

At any rate we’ll get it sorted. Let me know what you find out : )

Edit2

Yea so you have it being isSea but consuming 1 Inf. You can only place isSea units in SZs and the Inf would have to be on a trprt. My guess is Drydock shouldn’t be a sea unit ?

@barnee

Hi barnee,

Yes, the drydock is really only needed to accommodate the battleships. The drydock is basically a carrier because the hulls are air units. It was the only way to get a land unit to water.

Also, drydocks are not placed, they are bought and kept in buy window forever, never consumed. It makes the game engine think you have a carrier waiting to be placed.

The notification while moving the hull into water is not an error, just telling you there are air units (the hulls) that would have to be placed on a carrier. Perhaps explaining the notifications and all of this would be good though.

The drydock is a sea unit, and I made it consume an inf so that it basically could never consume anything.

You have the logic all figured out, but not why I did it =p

@barnee

I didn’t want the drydock to be floating in the water, and it being on land doesn’t accommodate the game engine problem of moving a land unit into water to be consumed.

@waxfingers Right on. I would suggest some clarification in the Game Notes how it works. When it doubt, “go over explanatory”, someone once told me : )

It just looked so cool I wanted to see it on the board lol. But yea only so much room. It did make me wonder because you have it bombable . Do we need it in the Purchase Window then ?

Anyway, I adjusted your Game Notes slightly. I usually try and always capitalize the first letter/character in the unit for consistency. I don’t always ( because I’m a buzzhead lol ) and Idk if it’s always the way to go, but I do Battleship and Infantry for example.

Anyway, I think we can roll after some Note updates. I’ll send ya what I have

@barnee

Yeah, I was wondering about having it as a playable unit and bombable, but then found out it can’t really be on the board.

Actually, do you know how to load purchases into peoples existing purchases at game setup? I would prefer to just load it into peoples buys so that it is not forgotten if the 2 round purchase option is selected. People only need 1 since it never gets consumed, and it has like 10 carrier capacity.

I will add in some more clarification to the notes.

@barnee

Here, you can add this in/replace the notes.

Capital ships require an existing Hull from a previous round in order to build the finished sea unit. Carriers can be built from either a Carrier Hull or a Battleship Hull (albeit more expensive by being built from Battleship Hulls), but Battleships can only be built from Battleship Hulls.<br><br>
During the purchase phase of the round that you want to place a Carrier or Battleship you must also have a Drydock in your purchases. Only one Drydock needs to be purchased per game as it stays within your purchases and cannot be consumed. The Drydock is required specifically for the game engine to launch Battleships.<br><br>
The Hull(s) that you intend to convert to finished unit(s) need to be moved to the chosen sea zone during non combat. If this step is missed then one needs to edit in the complete unit(s), remove the hull(s), take note of purchases remaining, and perhaps reduce PUs by the purchases remaining that could not be placed properly.<br>
<br>

@waxfingers said in G40 Redesign (currently taking suggestions):

Actually, do you know how to load purchases into peoples existing purchases at game setup?

Hmm…yea Idk. I think something can be done where everyone auto gets it but it’s not placed . Have to look into it.

You might wanna ask at the triplea site under Map Making

https://forums.triplea-game.org/category/28/map-making

@barnee

I got another play test in today. Found out an issue, kind of. My save game thing I discovered I have to save at the German phase otherwise all of the map options turn off again haha. Loaded a game saved at Changer and my setup hulls, purchase window for hulls, and French BB were all there so I thought the game was good to go. It wasn’t until Vichy did not happen that we were like huh.
Checked map options and they were all turned off. I think there is something different with my code of when it loads into the game because I make the Changer add the stuff or it loads on game initiation. I was able to turn off some other map options and then reload and they turned off before German start.

OK… wait I just tested and the same thing happens with other code (e.g. escort carriers), it seems that code loads it permanently into the game after German turn. What I did to test was loaded a game with Escort carriers, then saved and turned it off. They did not appear for Germany. Then did it again but this time saved after German turn, turned off. Loaded for Russia, they were still there locked into game purchases. I guess mine just was done during Changer or game initiation vs German phase. Not sure if you want to change that. Really this is not an issue for a fresh game, it was just something discovered for me saving a game right after loading it. I noticed the 2 hit cruisers/BBs also make more units appear into the game at the start of Germany rather than game initiation. I can dig into the code and set to German player, etc if you think it would be better.